Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es-ES) Spanish Spain translation #4495

Merged
merged 10 commits into from
Feb 6, 2024
Merged

i18n(es-ES) Spanish Spain translation #4495

merged 10 commits into from
Feb 6, 2024

Conversation

joebordes
Copy link
Contributor

@joebordes joebordes commented Dec 24, 2023 •
edited

  • New feature (non-breaking change which adds functionality)

Proposed changes

Spanish Spain translation

Checklist

  • I have read the contribution guidelines
  • [-] For non-bugfix PRs, I have discussed this change on the forum/slack team.
    • I read the forum posts
  • I have run npm run test to verify the unit tests pass
  • [-] I have added suitable unit tests to cover the new/changed functionality
    • not needed? I reviewed the translation in the UI and will continue to do so in the next days as I work with the product

@marcus-j-davies
Copy link

@Steve-Mcl or @dceejay

can you re-trigger the workflow? - seems to be stuck for a translation PR

GogoVega
GogoVega reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@GogoVega GogoVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Joe,
The #4531 introduces a global list for available languages - I added two suggestions to align with this PR.

packages/node_modules/@node-red/editor-client/locales/es-ES/editor.json Outdated Show resolved Hide resolved
packages/node_modules/@node-red/editor-client/locales/en-US/editor.json Outdated Show resolved Hide resolved
@joebordes
Copy link
Contributor Author

Thank you @GogoVega I made the suggested changes and synced the translations with latest changes on master branch

@knolleary knolleary merged commit 0b7e8ec into node-red:master Feb 6, 2024
4 checks passed
@joebordes
Copy link
Contributor Author

great!! Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GogoVega GogoVega GogoVega left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joebordes @marcus-j-davies @GogoVega @knolleary